-
Notifications
You must be signed in to change notification settings - Fork 45.4k
Fix eval_config field - eval_interval_secs not working #5144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a must have imo. Please merge it! |
Could you please resolve the conflicts ? |
Gents, Have this been fixed and applied fully in latest tensorflow object detection repo so we can re-download it ? This is killing us... Thanks, |
Any progress with the issue? |
Fix conflicts with current master branch
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
1 similar comment
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@pkulzc Please review this pull request. |
Hi ! |
I think eval_interval_secs is originally designed to be passed as one of EvalSpec parameter - throttle_secs, which defines the frequency of saving checkpoint and evaluation.
Because setting eval_interval_secs is not working, there is no other way to change the frequency of evaluation.
Therefore, I simply parse eval_interval_secs from eval config and pass it to EvalSpec as a parameters to complete this functionality.