Skip to content

Conversation

jejarosl
Copy link
Contributor

@jejarosl jejarosl commented Apr 13, 2021

Description

Adding the CNN Image Retrieval model implementation based on the following papers:

[1] Fine-tuning CNN Image Retrieval with No Human Annotation,
Radenović F., Tolias G., Chum O., TPAMI 2018 [arXiv]
https://arxiv.org/abs/1711.02512

[2] CNN Image Retrieval Learns from BoW: Unsupervised Fine-Tuning with Hard
Examples, Radenović F., Tolias G., Chum O., ECCV 2016 [arXiv]
https://arxiv.org/abs/1604.02426

Type of change

  • New feature (non-breaking change which adds functionality)
  • A new research paper code implementation

@jejarosl jejarosl requested a review from andrefaraujo as a code owner April 13, 2021 19:31
@google-cla google-cla bot added the cla: yes label Apr 13, 2021
Copy link
Member

@andrefaraujo andrefaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kate! Please take a look at the comments :)

@andrefaraujo
Copy link
Member

Thanks for the new commit Kate! I saw a couple more minor code style issues, see new comments.

Regarding the function that applies whitening, it would be great if we could consolidate / avoid duplication with the other one I mentioned. LMK if that ends up being possible :)

Copy link
Member

@andrefaraujo andrefaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kate, looks great!

@andrefaraujo andrefaraujo merged commit 79946a7 into tensorflow:master Apr 16, 2021
@andrefaraujo andrefaraujo mentioned this pull request Apr 20, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants