Allow TFL to TOSA pipeline to load TFL dialect #95205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After c03f377, the TFL dialect is no longer part of common dialects, and `tf-tosa-opt --tofl-to-tosa-pipeline` would no longer be able to convert from TFL since the dialect was no longer available.
|
FWIW, I do not understand how tests that use Locally I'm seeing the following error on main w/o this patch: bazel-bin/tensorflow/compiler/mlir/tosa/tf-tosa-opt --tfl-to-tosa-pipeline ~/emitc/model.mlir -o ~/emitc/model_tosa.mlir
/usr/local/google/home/paulkirth/emitc/model.mlir:3:28: error: operation being parsed with an unregistered dialect. If this is intended, please use -allow-unregistered-dialect with the MLIR tool used
%0 = "tfl.pseudo_const"() <{value = dense<1> : tensor<2xi32>}> : () -> tensor<2xi32> |
|
cc: @mtrofin |
mtrofin
approved these changes
Jun 13, 2025
github-project-automation
bot
moved this from Assigned Reviewer
to Approved by Reviewer
in PR Queue
google-ml-butler
bot
added
kokoro:force-run
|
@jpienaar is this ok to land ? If so, I can proceed. |
jpienaar
approved these changes
Jun 18, 2025
github-project-automation
bot
moved this from Approved by Reviewer
to Merged
in PR Queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After c03f377, the TFL dialect is no longer part of common dialects, and
tf-tosa-opt --tofl-to-tosa-pipelinewould no longer be able to convert from TFL since the dialect was no longer available.