[tfjs-node] Support saving trainingConfig and userDefinedMetadata #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In NodeFileSystem IOHandler, make sure that trainingConfig and userDefinedMetadata are handle during saved and load. - Also populate the format, generatedBy and convertedBy fields. - Add unit tests. FEATURE
kangyizhang
approved these changes
Aug 27, 2019
|
@nkreeger let me know if you have any comments. If not, I'll merge the PR some time today. Thanks. |
|
Merging this PR now. @nkreeger @kangyizhang Let me know if you have remaining comments and I'll be happy to address them in follow-up PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and userDefinedMetadata are handle during saved and load.
Fixes #83
Fixes #1596
FEATURE
This change is