Add WebGPU to the release script #6209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lina128
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
Thank you Matt!
Reviewable status:
complete! 2 of 1 approvals obtained
|
Thanks Matt for integrating WebGPU into monorepo release. This is very meaningful for us! |
mattsoulanille
added a commit
to mattsoulanille/tfjs
that referenced
this pull request
Mar 18, 2022
\tensorflow#6209 made the release script overwrite every dependency in the set of packages being published. This causes tfjs-core's verdaccio tests to fail because tfjs-core has a devDependency on tfjs-backend-cpu, but core needs to be published before cpu. This PR reverts to the original behavior of overwriting dependency versions in the package.json only if they are listed in a given release phase's dependencies.
lina128
pushed a commit
that referenced
this pull request
Mar 18, 2022
* In release, replace only packages marked as deps \#6209 made the release script overwrite every dependency in the set of packages being published. This causes tfjs-core's verdaccio tests to fail because tfjs-core has a devDependency on tfjs-backend-cpu, but core needs to be published before cpu. This PR reverts to the original behavior of overwriting dependency versions in the package.json only if they are listed in a given release phase's dependencies. * Remove update-dependency.ts from e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow alpha packages that are part of the monorepo to be published alongside the monorepo with a different version number than the monorepo's version number. Add WebGPU as an alpha package.
Running
yarn release-tfjsproduces the following output. Since tfjs-backend-webgpu is an alpha package, the release script asks the user what version it should have.This produces the following PR: #6208.
Alpha packages can be added to the ALPHA_RELEASE_UNIT in release-util.ts.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is