Add has_database function and correct docstring of get_database #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has_database is better to check for existance of a database rather than using connect or catch the exception of get_database
GavinMendelGleason
approved these changes
Aug 24, 2022
Codecov Report
@@ Coverage Diff @@
## main #341 +/- ##
==========================================
+ Coverage 68.40% 68.44% +0.04%
==========================================
Files 10 10
Lines 3887 3892 +5
==========================================
+ Hits 2659 2664 +5
Misses 1228 1228
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
has_database is better to check for existence of a database rather than using connect or catch the exception of get_database