enhance(main/termux-tools): new motd design #11250
Conversation
TermuxMonet
requested review from
finagolfin,
Grimler91 and
landfillbaby
as code owners
Done |
Added a new termux motd dynamic design. Closes #11222 Co-authored-by: TomJo2000 <tomjo00@web.de>
|
Is this PR gonna be merged? |
LGTM, of course. Wait for the github action to finish before merging it. |
|
I think its better the previous motd design should be used or without the Termux logo. zooming in/out the terminal would mess the logo up and makes the motd unreadable in portrait screens |
|
This was mentioned to OP but wasn't removed. Text word wrap is fine, icon wrapping is not good and can't be avoided. Other changes are fine, didn't get time to test. |
|
Merged too early I guess... |
Too late for a hotfix? this can be fixed by adding a character (dot) inside the logo squares |
|
I don't think the existence of this micro logo is necessary, after I updated my terminal, he messed up my original layout, and I couldn't modify it at first, and the logo is very unaesthetic, yes it's very lacking aesthetics! |
|
And this move is superfluous, which makes my original modification method invalid, and I am very distressed |
|
The icon only is planned to be removed from new motd due to word wrap issue, rest will stay, didn't get time to fix. Can provide an env variable for users to have their own as well, so that whoever likes icons and stuff can use one easily without requiring modifications on package updates. |
btw I think I've worked out a solution to the line wrapping issue, I just haven't had the time to fully test it yet. |
|
I see, how are you doing it? |
what? |
By checking the |
Resizing after motd has already been generated will still break it and make it "unreadable". |
That's what I'm still working on. |
|
The env variable for custom motd file is a better option for you guys. The defaults should not break. Maybe an additional env variable that decides whether icon should be printed or not could be added too, then custom motd file will not need to be downloaded/created by users. |
That's also a good idea, I'll have to see when I have some time to work out the kinks on this. |
|
Thanks. If you can do it, then good. Note that |
|
I'll wanna make sure it's all working as intended before making a Pull Request, so I'll keep it in mind for later. |
|
Update on this. Hopefully I'll have time to touch this up and make a Pull Request over on termux-tools tomorrow, although I just started a new internship and I've been incredibly busy. |
- The logo added in new dynamic motd would break due to word wrap if terminal columns were less than max line length. This fixes the issue by not drawing a logo if terminal columns are too few at draw time. Note that logo will still break if terminal size is changed after drawing. - Use TERMUX_APP_PACKAGE_MANAGER instead of TERMUX_MAIN_PACKAGE_FORMAT - Add donate link instead of gitter which should already exist in community link, including matrix rooms link. Related pull requests termux/termux-packages#11250 and termux/termux-packages#11250
- The logo added in new dynamic motd would break due to word wrap if terminal columns were less than max line length. This fixes the issue by not drawing a logo if terminal columns are too few at draw time. Note that logo will still break if terminal size is changed after drawing. - Use TERMUX_APP_PACKAGE_MANAGER instead of TERMUX_MAIN_PACKAGE_FORMAT - Add donate link instead of gitter which should already exist in community link, including matrix rooms link. Related pull requests termux/termux-packages#11250 and termux/termux-packages#11294
- The logo added in new dynamic motd would break due to word wrap if terminal columns were less than max line length. This fixes the issue by not drawing a logo if terminal columns are too few at draw time. Note that logo will still break if terminal size is changed after drawing. - Use TERMUX_APP_PACKAGE_MANAGER instead of TERMUX_MAIN_PACKAGE_FORMAT - Add donate link instead of gitter which should already exist in community link, including matrix rooms link. Related pull requests termux/termux-packages#11250 and termux/termux-packages#11294
For aesthetic pruposes, changed the motd by adding a small termux icon, termux version display and a hint to fix repo issues related to termux-change repo.
And also, now login executes a dynamic motd.sh, which can expand environment variables and display text formatting.
Common motd support wasn't removed, since now the login just distinguishes between dynamic and common motd (prioritising the dynamic motd)
Preview:
(Duplicate of #11222. Previous commit got broken)
Co-authored-by: TomJo2000