libtalloc: Add missing dependency on libbsd

[monoidic]

$ readelf -d ~/../usr/lib/libtalloc.so | grep NEEDED
0x0000000000000001 (NEEDED)             Shared library: [libbsd.so]
0x0000000000000001 (NEEDED)             Shared library: [libdl.so]
0x0000000000000001 (NEEDED)             Shared library: [libc.so]

[tomty89]

Which binary repo / architecture are you on? I'm not seeing this on the android-5 aarch64 libtalloc. Neither does talloc on Arch appear to have dependency on libbsd.

[monoidic]

Version 2.1.14 from bintray (https://dl.bintray.com/termux/termux-packages-24/aarch64/:libtalloc_2.1.14_aarch64.deb). I just checked that .deb a desktop system:

$ dpkg -x libtalloc_2.1.14_aarch64.deb out
$ readelf -d out/data/data/com.termux/files/usr/lib/libtalloc.so | grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libbsd.so]
 0x0000000000000001 (NEEDED)             Shared library: [libdl.so]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so]

[ghost]

libbsd was picked accidentally because it was exist before libtalloc was built.

    # libbsd on some platforms provides strlcpy and strlcat
    if not conf.CHECK_FUNCS('strlcpy strlcat'):
        if conf.CHECK_FUNCS_IN('strlcpy strlcat', 'bsd', headers='bsd/string.h',
                               checklibc=True):
            strlcpy_in_bsd = True

This should not be merged unless there is a good reason to use functions from libbsd.

[monoidic]

Whatever fixes (packages depending on) libtalloc ¯\_(ツ)_/¯

[fornwall]

@monoidic Thanks for reporting!

This should be fixed by bd59d70 (applied both to master and the android-5 branch), which avoids linking in libbsd (and libtalloc only tried to link in that library for the strlcpy and strlcat functions, which is not needed since the Android libc already has those.