Add termshark

[gcla]

Termshark is a terminal UI for tshark. It's written in golang and as such
consists of one binary. This is a minimal termux build script to make
termshark available. Termshark depends on tshark at runtime, so tshark (from
wireshark) is a package dependency.

More info is available at https://github.com/gcla/termshark.

[Grimler91]

Cool! We don't have a package named wireshark though, but wireshark-gtk | tshark should do it (so that it requires either the gtk variant from x11-packages or tshark from termux-root-packges)

[ghost]

Dependencies must be present in repository. This PR should be opened in https://github.com/termux/termux-root-packages where tshark is available.

[gcla]

Apologies, I'll re-submit the PR there and withdraw this one.

[gcla]

Hi - I misunderstood something, and would love to get some advice :-)

Reading the docs, termux-root-packages is for users with rooted phones. I could submit termshark there, but termshark itself doesn't require a rooted phone, and indeed is probably more useful for inspection of pcap files e.g. download a pcap from somewhere onto your phone, then run termshark in termux to look at it (like wireshark). Or, I could submit against x11-packages and depend on wireshark-gtk, although termshark itself doesn't require X11 to run, just the tshark binary.

I tested termshark on termux by installing x11-packages and running the termshark binary to make sure it worked correctly. So maybe the best option would be to move the PR to x11-packages, and that would make it available to the most users?

Thanks!

[Grimler91]

@xeffyr I think wireshark-gtk | tshark makes most sense as wireshark-gtk also provides tshark. Cirrus-CI will still be able to build the package since ./build-package.sh -i can download from the other repos as well.

And if it depends on either wireshark-gtk or tshark then having it in termux-packages makes sense.

edit: No, sorry, ./build-package.sh -i won't work unless it knows which version to download, termux-root-packages might make the most sense then

[gcla]

Hi @xeffyr and @Grimler91 - thanks for the advice. I understand now that even though packages in termux-root-packages are expected to require a rooted phone, as a non-rooted-phone user, I can still enable the repo and install from that source if I want. So putting termshark in this package source won't limit its availability to a smaller subset of termux users. I'll move the PR over there!