Update ndk to r22 #6174
Update ndk to r22 #6174
Conversation
|
bitcoin, dash, ed (and probably a few others) fails with: Deleting the asm-generic-termbits.h.patch makes the builds work. We added that patch to solve this issue: #1359. |
|
dns2tcp, heyu and sharutils fails with this type of error |
|
libtirpc needs |
Probably |
|
@xeffyr yes, removing that patch makes the build succeed. Libwren fails with: |
I wonder if this is worth reporting up to https://github.com/android/ndk |
|
@tmm1 thanks, you might want to include more information in that bug report, see the bug report template: https://github.com/android/ndk/blob/master/.github/ISSUE_TEMPLATE/bug-report.md. Specifically a small test case for reproducing the problem is useful |
|
Libdispatch fails with |
|
libvpx fails with |
|
I'll look into the libdispatch issue, that |
|
|
|
That was all types of failures related to the ndk update encountered during a |
|
the golang issue was fixed just now by @xeffyr so you can check that off the list :) |
|
As noted on the NDK issue, the clang default was changed to |
Should we revert this for |
|
I lean towards fixing the packages instead, even though it's more work. Both gcc and clang have switched that flag off by default now, so most packages will have to patch those over time anyway. |
Yeah, it works when building locally on termux now. We also have to patch the downloaded host golang package, or wait for the next release |
|
They recently bumped the LTS NDK to 21e, we should use that for now. I asked and NDK 22 is a rolling release, so maybe we just put this pull off till the next LTS release? |
If this is still needed (see issue #1359) then we will have to workaround it in some other way.
Fixes error
```
In file included from man_html.c:23:
In file included from /home/builder/.termux-build/_cache/android-r22-api-24-v3/bin/../sysroot/usr/include/ctype.h:39:
/home/builder/.termux-build/_cache/android-r22-api-24-v3/bin/../sysroot/usr/include/bits/ctype_inlines.h:81:27: error: static declaration of 'isblank' follows non-static declaration
In file included from mdoc_html.c:23:
In file included from /home/builder/.termux-build/_cache/android-r22-api-24-v3/bin/../sysroot/usr/include/ctype.h:39:
/home/builder/.termux-build/_cache/android-r22-api-24-v3/bin/../sysroot/usr/include/bits/ctype_inlines.h:81:27: error: __BIONIC_CTYPE_INLINE int isblank(int __ch) {static declaration of 'isblank' follows non-static declaration
```
Fixes error
```
util.c:47:1: error: redefinition of 'swab'
swab (const void *bfrom, void *bto, ssize_t n)
^
/home/builder/.termux-build/_cache/android-r22-api-24-v3/bin/../sysroot/usr/include/bits/swab.h:41:27: note: previous definition is here
__BIONIC_SWAB_INLINE void swab(const void* __void_src, void* __void_dst, ssize_t __byte_count) {
^
1 error generated.
make[3]: *** [/home/builder/.termux-build/netpbm/src/common.mk:272: util.o] Error 1
make[3]: *** Waiting for unfinished jobs....
```
Patch from @buttaface. This commit is responsible: aosp-mirror/platform_bionic@76e2b15
| @@ -3,6 +3,7 @@ TERMUX_PKG_DESCRIPTION="System header and library files from the Android NDK nee | |||
| TERMUX_PKG_LICENSE="NCSA" | |||
| TERMUX_PKG_MAINTAINER="@termux" | |||
| TERMUX_PKG_VERSION=$TERMUX_NDK_VERSION | |||
| TERMUX_PKG_REVISIOM=1 | |||
|
@Grimler91 I don't know why... but I ran the docker image and running |
|
@suhan-paradkar You can run setup-android-sdk.sh only when Docker image is building. Once image build is about to finish, the cleanup steps are being executed which remove unnecessary components from SDK bundle to shrink the resulting image size.
|
|
Thanks..👍 |
|
@Buttface I hope it won't stop be able to run in Android first, heh, with all the security whatsoever back-and-forth changes that has come / will come... |
This one(if I am not wrong) is again due to and a file This scenario causes the error (correct me if I am wrong)... |
|
A new LTS NDK was released a couple days ago, NDK 23, we should switch to that. |
|
I'll close this and start over from r23 |
Issues:
error: duplicate symbol: x_cgo_inittlserror: duplicate symbol, see (Update ndk to r22 #6174 (comment))error: conflicting types for 'ffsl'(fixed, see Update ndk to r22 #6174 (comment))libwren fails withnvm, does not happen in docker imageerror: --fix-cortex-a53-843419 is only supported on AArch64 targets, see Update ndk to r22 #6174 (comment)error: templates must have C++ linkage, see Update ndk to r22 #6174 (comment), fixed in 7d1ee40isblank, see Update ndk to r22 #6174 (comment)swab, fixed in c63ce1dTrying to build any go package gives:
Which is reported here in the golang repo: golang/go#42655