-
-
Notifications
You must be signed in to change notification settings - Fork 704
feat: Support aws_lb_listener_rule.transform, regex_values, and update docs
#422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support aws_lb_listener_rule.transform, regex_values, and update docs
#422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great - one minor comment on removing the pluralization
| - Security group rules now use a default naming scheme of `<security-group-name>-<map-key>` unless a more specific rule name is provided. | ||
| - `rule.actions.type` has been replaced with `rule.actions.<type>`. See before/after below for more details. | ||
| - `query_string` supports a list of key:value pairs; type definition updated to support this (i.e. was `map(string)` and is now `list(map(string))`) | ||
| - `aws_lb_listener.ssl_policy` now defaults to `ELBSecurityPolicy-TLS13-1-3-2021-06` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you ❤️
main.tf
Outdated
| priority = each.value.priority | ||
|
|
||
| dynamic "transform" { | ||
| for_each = each.value.transforms != null ? each.value.transforms : {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we've been inconsistent elsewhere but lets match the API with the singular form
| for_each = each.value.transforms != null ? each.value.transforms : {} | |
| for_each = each.value.transform != null ? each.value.transform : {} |
variables.tf
Outdated
| listener_key = optional(string) | ||
| priority = optional(number) | ||
| tags = optional(map(string), {}) | ||
| transforms = optional(map(object({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| transforms = optional(map(object({ | |
| transform = optional(map(object({ |
## [10.1.0](v10.0.2...v10.1.0) (2025-11-01) ### Features * Support `aws_lb_listener_rule.transform`, `regex_values`, and update docs ([#422](#422)) ([2f90229](2f90229))
|
This PR is included in version 10.1.0 🎉 |
Description
Support
aws_lb_listener_rule.transformblock.Support
regex_valuesincondition.host_header,condition.http_header, andcondition.path_pattern.Update v10 upgrade doc to specify new
ssl_policydefault.Motivation and Context
Breaking Changes
No.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request