Skip to content

Conversation

@magreenbaum
Copy link
Member

Description

Support aws_lb_listener_rule.transform block.
Support regex_values in condition.host_header, condition.http_header, and condition.path_pattern.
Update v10 upgrade doc to specify new ssl_policy default.

Motivation and Context

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great - one minor comment on removing the pluralization

- Security group rules now use a default naming scheme of `<security-group-name>-<map-key>` unless a more specific rule name is provided.
- `rule.actions.type` has been replaced with `rule.actions.<type>`. See before/after below for more details.
- `query_string` supports a list of key:value pairs; type definition updated to support this (i.e. was `map(string)` and is now `list(map(string))`)
- `aws_lb_listener.ssl_policy` now defaults to `ELBSecurityPolicy-TLS13-1-3-2021-06`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ❤️

main.tf Outdated
priority = each.value.priority

dynamic "transform" {
for_each = each.value.transforms != null ? each.value.transforms : {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we've been inconsistent elsewhere but lets match the API with the singular form

Suggested change
for_each = each.value.transforms != null ? each.value.transforms : {}
for_each = each.value.transform != null ? each.value.transform : {}

variables.tf Outdated
listener_key = optional(string)
priority = optional(number)
tags = optional(map(string), {})
transforms = optional(map(object({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
transforms = optional(map(object({
transform = optional(map(object({

@bryantbiggs bryantbiggs merged commit 2f90229 into terraform-aws-modules:master Nov 1, 2025
9 checks passed
antonbabenko pushed a commit that referenced this pull request Nov 1, 2025
## [10.1.0](v10.0.2...v10.1.0) (2025-11-01)

### Features

* Support `aws_lb_listener_rule.transform`, `regex_values`, and update docs ([#422](#422)) ([2f90229](2f90229))
@antonbabenko
Copy link
Member

This PR is included in version 10.1.0 🎉

@magreenbaum magreenbaum deleted the feat/support_transform branch November 1, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants