feat: Add ability to enable cross-zone load balancing #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@biancarosa This looks good, just add a |
biancarosa
changed the title
Contributor
Author
|
@dynamike i've done that + added as ready for review! still didn't have the time to go through all the testing stages so i'd appreciate help with that or I can do that at some point next week |
bryantbiggs
changed the title
bryantbiggs
approved these changes
Dec 15, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Dec 15, 2022
## [3.26.0](v3.25.0...v3.26.0) (2022-12-15) ### Features * Add ability to enable cross-zone load balancing ([#326](#326)) ([1d1c75f](1d1c75f))
Member
|
This PR is included in version 3.26.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds possibility of enabling cross zone load balancing.
Motivation and Context
My TF plan was warning me because of a manual change on the load balancer and I went to update the tf code to enable cross zone load balancing and atlantis didn't support this parametrization of the
aws-lb.Breaking Changes
N/A
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request