-
-
Notifications
You must be signed in to change notification settings - Fork 740
fix: Make quiet_archive_local_exec properly suppress Poetry/pip/npm output #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make quiet_archive_local_exec properly suppress Poetry/pip/npm output #709
Conversation
2b74a51
to
64c6e71
Compare
99c324d
to
7555e62
Compare
…utput - Pass quiet flag from Terraform to package.py via query data - Add quiet flag to build_data dictionary in prepare_command - Suppress stdout/stderr in Poetry, pip, and npm subprocess calls when quiet=true - Add example demonstrating quiet packaging functionality - Update documentation and apply formatting fixes Fixes issue where quiet_archive_local_exec only affected Terraform's local-exec output but not the actual Poetry/pip/npm subprocess calls within package.py. Resolves terraform-aws-modules#706
7555e62
to
3d1b3e3
Compare
@antonbabenko just tagging for visibility! Appreciate any time you have to review |
Hey @ruhrohraggy - thanks for working on this! I've been testing out your PR and found that it's missing a variable declaration for |
@hristost-pearl |
Should be... Like #706 pointed out, it was just that the variable didn't seem to be getting applied as expected. |
## [8.1.2](v8.1.1...v8.1.2) (2025-10-22) ### Bug Fixes * Make quiet_archive_local_exec properly suppress Poetry/pip/npm output ([#709](#709)) ([bae0385](bae0385))
This PR is included in version 8.1.2 🎉 |
Thanks @antonbabenko ! |
Description:
The quiet_archive_local_exec variable was not being honored by the actual packaging subprocess calls in package.py. This change passes the
quiet flag from Terraform to the Python script and suppresses all packaging output when enabled.
Problem:
• quiet_archive_local_exec only suppressed Terraform's local-exec output, not the actual packaging commands
• Poetry, pip, npm, and zip subprocess calls were still producing verbose output during builds
• Users experienced noisy Terraform output during Lambda packaging operations
Solution:
• Pass quiet flag from Terraform → package.py → build plan → subprocess execution
• Suppress stdout/stderr in Poetry, pip, and npm check_call() when quiet=true
• Suppress zip creation and file logging in ZipWriteStream when quiet=true
• Suppress completion messages when quiet=true
Changes Made:
• Add quiet to build plan data in prepare_command
• Suppress Poetry/pip/npm subprocess output when query.quiet is true
• Add quiet parameter to ZipWriteStream class
• Suppress zip logging and completion messages when quiet mode enabled
Testing:
• [x] Added package_dir_poetry_quiet example demonstrating quiet_archive_local_exec = true
• [x] Verified Poetry, pip, npm, and zip output is suppressed in quiet mode
• [x] Confirmed backward compatibility - no output change when quiet_archive_local_exec = false
• [x] All pre-commit hooks pass successfully
Breaking Changes:
None. This is a backward-compatible bug fix.
Resolves:
• fixes #706 - quiet_archive_local_exec not working for Poetry/pip/npm output
• Provides truly quiet Lambda packaging builds for cleaner Terraform output