refactor: #12415/Cross Object Referencing and Terraform Upgrade

[mukulpalit-ibm]

Description

• Upgraded terraform version to 1.9.0
• Migrated and tested 4 Validations to variables.tf for main module.
  Issue

Validation Tests

Case 1 :

cloud_monitoring_enabled         = true
cloud_monitoring_access_key      = null
cloud_monitoring_instance_region = null

Case 2 :

cloud_monitoring_enabled         = true
cloud_monitoring_access_key      = null
cloud_monitoring_instance_region = ""

Case 3 :

cloud_monitoring_enabled         = true
cloud_monitoring_access_key      = ""
cloud_monitoring_instance_region = null

All the above cases leads to the following error

Which is resolved with

cloud_monitoring_enabled         = true
cloud_monitoring_access_key      = ""
cloud_monitoring_instance_region = ""

Case 4 :

logs_agent_enabled     = true
cloud_logs_ingress_endpoint     = null

Case 5 :

logs_agent_enabled      = true
cloud_logs_ingress_endpoint     = ""

Case 4 and 5 leads to the following error

which is resolved with

logs_agent_enabled        = true
cloud_logs_ingress_endpoint     = "Non Empty String"

Case 6 :

logs_agent_enabled               = true
logs_agent_iam_mode              = "TrustedProfile"
logs_agent_trusted_profile       = null

Case 7 :

logs_agent_enabled               = true
logs_agent_iam_mode              = "TrustedProfile"
logs_agent_trusted_profile       = ""

Case 6 and 7 leads to the following error

which is resolved with

logs_agent_enabled               = true
logs_agent_iam_mode              = "TrustedProfile"
logs_agent_trusted_profile       = "Non Empty String"

Case 8 :

logs_agent_enabled               = true
logs_agent_iam_mode              = "IAMAPIKey"
logs_agent_iam_api_key       = null

Case 9 :

logs_agent_enabled               = true
logs_agent_iam_mode              = "IAMAPIKey"
logs_agent_iam_api_key       = ""

Case 8 and 9 leads to the following error

which is resolved with

logs_agent_enabled               = true
logs_agent_iam_mode              = "IAMAPIKey"
logs_agent_iam_api_key       = "Non Empty String"

All validations passed when the enabled flags are false

cloud_monitoring_enabled         = false
cloud_monitoring_access_key      = null
cloud_monitoring_instance_region = null
logs_agent_enabled               = false
cloud_logs_ingress_endpoint      = null
logs_agent_iam_mode              = ""
logs_agent_trusted_profile       = null
logs_agent_iam_api_key           = null

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[mukulpalit-ibm]

/run pipeline

[mukulpalit-ibm]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 2.6.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀