Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump HikariCP from 3.3.0 to 3.3.1 in /modules/junit-jupiter #1227

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Feb 8, 2019

Bumps HikariCP from 3.3.0 to 3.3.1.

Changelog

Sourced from HikariCP's changelog.

HikariCP Changes

Changes in 3.3.1

  • fixed 1287 set core pool size before max pool size

  • fixed 1308 treat a SQLTimeoutException as an evictable offense

  • do not default maxPoolSize to minIdle when only minIdle is specified

  • do not log warning about idleTimeout unless minimumIdle is less than maxPoolSize (because otherwise
    it does not apply)

Changes in 3.3.0

  • Revert change where Connection.isClosed() was called outside of setNetworkTimeout() block, opening
    vulnerability to unacknowledged TCP traffic.

  • fixed 1186 limit number of items in the ConcurrentBag's ThreadLocal list to avoid OOM errors in some
    borrow/requite patterns.

  • Merged changed to log uncaught (Throwable) exceptions during connection acquisition.

  • fixed 1161 fix logging formatting anchor.

  • fixed 1181, 1182 allow passing a Prometheus CollectorRegistry rather than always using the default
    registry.

  • merged 1210 use orElseGet() to delay call until necessary with respect to the housekeeper thread
    factory.

  • fixed 1074 capability to instantiate an object based on the String class name, usefull when you want
    to set the MetricsTackerFactory from a property.

  • merged 1250 fix proxy classes generation reproducibility using a sorted LinkedHashSet

  • various clean-ups pointed out by sonarcloud.io

  • merged 1290 Class.newInstance() is deprecated as of Java 9. Usage should be replaced by calling
    Class.getDeclaredConstructor().newInstance().

  • fixed #1305 ensure that ConcurrentBag.add() does not spin under high load, when waiting threads may never
    reach 0.

  • fixes #1287 when system property blockUntilFilled is set, use multiple threads to fill the pool.

Changes in 3.2.0

  • check connection closed condition before attempting to set network timeout to avoid spurios exceptions
... (truncated)
Commits
  • 86cabf0 [maven-release-plugin] prepare release HikariCP-3.3.1
  • 162ebef Update CHANGES
  • e8e9cdd fixes #1287 set core pool size before max pool size
  • 28a2afd fixed idle validation test case
  • 86612b4 Do NOT default maxPoolSize to minIdle when only minIdle is specified.
  • cda2605 Fixes #1308 treat a SQLTimeoutException as an evictable offense
  • 80d382d Fix idle timeout test case.
  • c742e86 Do not log warning about idleTimeout unless minimumIdle is less than maxPoolS...
  • b183aa1 Fixes #1319 update changelog
  • 8384617 Update README.md
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @kiview.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file java labels Feb 8, 2019
@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/modules/junit-jupiter/com.zaxxer-HikariCP-3.3.1 branch from b3e94ef to ae23609 Compare February 8, 2019 07:42
@kiview
Copy link
Member

kiview commented Feb 8, 2019

@dependabot squash and merge

@kiview
Copy link
Member

kiview commented Feb 8, 2019

@dependabot merge

@dependabot-preview dependabot-preview bot merged commit 144b886 into master Feb 8, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/gradle/modules/junit-jupiter/com.zaxxer-HikariCP-3.3.1 branch February 8, 2019 08:07
@greysteil
Copy link

FYI, I think the slowness to merge here was because Dependabot was waiting for CI to pass on it.

@bsideup bsideup added this to the next milestone Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants