-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acceptLicense method to MSSQLServerContainer #2085
Conversation
For issue #2050 |
46d16b3
to
82b118a
Compare
033e81b
to
9470b79
Compare
513e99b
to
f3a51a4
Compare
Resolved merge conflicts |
f3a51a4
to
fcc67fc
Compare
fcc67fc
to
975715b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this has languished for a long time, @KyleAure. I think this is fine and doesn't require any changes. Thank you for the contribution 🙇♂️
@rnorth thank you so much! It looks like I don't have authorization to merge. |
@KyleAure yep - will do now 😄 |
Fixes: #2050
Adds accept license method to the MSSQLServerContainer class while still allowing users to accept the license via a resource file. Updated customizable test class to use the new method, while the simple test class uses the resource file. Also updated documentation.