Skip to content

Conversation

nickserv
Copy link
Member

No description provided.

working_directory: ~/project/repo

cache_key: &cache_key angular-testing-library-deps-cache-{{ checksum "yarn.lock" }}
cache_key: &cache_key angular-testing-library-deps-cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason of the lockfile was to cache.
I think that with this change, we should also remove cache_key and the cache usage for the CI?
That being said, I was considering to move to GH Actions, so perhaps now would be the perfect time...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know the optimal way to handle this with Circle, so feel free to make changes if you want. Or you can switch to Actions and I'll update this PR to use it instead.

@timdeschryver
Copy link
Member

Resolved by #138

@nickserv nickserv deleted the nickmccurdy-patch-1 branch September 27, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants