Skip to content

Conversation

portothree
Copy link
Contributor

Hello,

I was reading #162 and also found useful to have a FAQ section and have included the question mentioned in the issue as the first one. Hope this helps!

@rafaelss95
Copy link
Contributor

Nice, @portothree... it will certainly help :)

@@ -218,6 +219,11 @@ Contributions of any kind welcome!
[**Read The Docs**](https://testing-library.com/angular) |
[Edit the docs](https://github.com/testing-library/testing-library-docs)

## FAQ

##### I am using Reactive Forms and the `jest-dom` matcher `toHaveFormValues` always returns an empty object or there are missing fields. Why?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about mentioning the directive proposed by @timdeschryver?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this one already, because it helps other devs.
Feel free to update this and mention the directive @rafaelss95 .

@timdeschryver timdeschryver merged commit a40f6fd into testing-library:master Nov 10, 2020
@timdeschryver
Copy link
Member

Thanks @portothree !

@all-contributors please add @portothree for docs

@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @portothree! 🎉

@github-actions
Copy link

🎉 This PR is included in version 10.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants