Skip to content

feat: remove detectChanges in favor of detectChangesOnRender #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2022
Merged

feat: remove detectChanges in favor of detectChangesOnRender #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions projects/testing-library/src/lib/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,22 +89,6 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
* })
*/
autoDetectChanges?: boolean;
/**
* @description
* Will call detectChanges when the component is compiled
*
* @default
* true
*
* @example
* const component = await render(AppComponent, {
* detectChanges: false
* })
*
* @deprecated
* Use `detectChangesOnRender` instead
*/
detectChanges?: boolean;
/**
* @description
* Invokes `detectChanges` after the component is rendered
Expand Down
6 changes: 1 addition & 5 deletions projects/testing-library/src/lib/testing-library.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ export async function render<SutType, WrapperType = SutType>(
): Promise<RenderResult<SutType>> {
const { dom: domConfig, ...globalConfig } = getConfig();
const {
detectChanges: detectChangesDeprecated = true,
detectChangesOnRender: detectChangesOnRenderInput,
detectChangesOnRender = true,
autoDetectChanges = true,
declarations = [],
imports = [],
Expand All @@ -67,9 +66,6 @@ export async function render<SutType, WrapperType = SutType>(
defaultImports = [],
} = { ...globalConfig, ...renderOptions };

const detectChangesOnRender =
detectChangesOnRenderInput === undefined ? detectChangesDeprecated : detectChangesOnRenderInput;

dtlConfigure(domConfig);

TestBed.configureTestingModule({
Expand Down