Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make wrapper component standalone: false explicitly #498

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

lacolaco
Copy link
Contributor

@lacolaco lacolaco commented Nov 8, 2024

Since Angular v19, components are set as standalone: true by default, but ATL is currently supporting only non-standalone wrapper. For forward-compatibility, make default wrapper standalone: false explicitly.

Since Angular v19, components are set as standalone: true by default, but ATL is currently supporting only non-standalone wrapper. For forward-compatibility, make default wrapper `standalone: false` explicitly.
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lacolaco !

@timdeschryver timdeschryver merged commit 5a0665f into testing-library:main Nov 9, 2024
4 checks passed
@lacolaco lacolaco deleted the v19-compat-wrapper branch November 11, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants