Skip to content

Conversation

timdeschryver
Copy link
Member

No description provided.

@timdeschryver timdeschryver changed the title feat: add waitForElement and waitForElementToBeRemoved feat: add waitForDomChange, waitForElement, waitForElementToBeRemoved Dec 3, 2019
@timdeschryver
Copy link
Member Author

timdeschryver commented Dec 3, 2019

cc @GregOnNet , I think this would also provide a solution to #38 (instead of using tick and detectChanges manually).

@GregOnNet
Copy link
Contributor

Hi,

this looks awesome.
I also like the naming.
It adds more meaning than tick.
Nice job. 👍

@timdeschryver timdeschryver changed the title feat: add waitForDomChange, waitForElement, waitForElementToBeRemoved feat: waitForDomChange, waitForElement, waitForElementToBeRemoved Dec 4, 2019
@timdeschryver timdeschryver merged commit a3975cd into master Dec 4, 2019
@timdeschryver timdeschryver deleted the wait-for-element branch December 4, 2019 07:45
@timdeschryver
Copy link
Member Author

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants