Skip to content

Conversation

kentcdodds
Copy link
Member

What:

log available roles when a roles query fails

Why:

Closes #286

How:

Make a prettyRoles export and use that in the missing error message

Checklist:

  • Documentation added to the
    docs site N/A
  • Typescript definitions updated N/A
  • Tests
  • Ready to be merged

@kentcdodds kentcdodds force-pushed the pr/log-available-roles branch from 7b051b1 to 140bee7 Compare July 12, 2019 17:51
@codecov-io
Copy link

codecov-io commented Jul 12, 2019

Codecov Report

Merging #321 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #321   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines         305    307    +2     
  Branches       65     65           
=====================================
+ Hits          305    307    +2
Impacted Files Coverage Δ
src/role-helpers.js 100% <100%> (ø) ⬆️
src/queries/role.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4083c...140bee7. Read the comment docs.

@kentcdodds kentcdodds merged commit 8c99171 into master Jul 12, 2019
@kentcdodds kentcdodds deleted the pr/log-available-roles branch July 12, 2019 17:54
@kentcdodds
Copy link
Member Author

🎉 This PR is included in version 5.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log available roles when *ByRoles query fails
2 participants