Skip to content

Conversation

yardenshoham
Copy link
Contributor

What:

Added my self to .all-contributorsrc.

Why:

I was asked by @gnapse in #130.

How:

Simply added another JSON to .all-contributorsrc.
Checklist:

  • Documentation N/A
  • Tests N/A
  • Updated Type Definitions N/A
  • Ready to be merged

@gnapse
Copy link
Member

gnapse commented Sep 19, 2019

Can you please also update this file to include a new entry in the checklist saying "Added myself to the contributors list". If you can't no worries, I can take care of it too.

@gnapse
Copy link
Member

gnapse commented Sep 19, 2019

Also, there's something missing here. I'm pretty sure that after you add yourself there's some command to be run to update the README so you also appear on it. That's auto generated by some command. Maybe @kentcdodds can help me refresh my mind about this as I do not recall how it's done.

@afontcu
Copy link
Member

afontcu commented Sep 19, 2019

Hi!

I don't think it should done manually – instead, an admin should mention all-contributors as in here: testing-library/dom-testing-library#344 (comment)

(in this case, "add @yardenshoham for docs", I guess)

@yardenshoham
Copy link
Contributor Author

@gnapse I added the changes you requested. I had to google how to do it and found this tool. I agree with @afontcu, the bot should be used - it was created for this purpose.

@gnapse
Copy link
Member

gnapse commented Sep 19, 2019

Ok nice, I did not know that bot existed. I tried it out in #130 and it's working, it created #132 so I think we can close this PR and will merge that one. Sorry to having made you waste a bit of time on this @yardenshoham. Thanks @afontcu for pointing this out to us.

@gnapse gnapse closed this Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants