chore: typo in to-have-attribute.js comment #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 45: Asymettic matchers --> Asymmetric matchers
alexkrolick
changed the title
afontcu
approved these changes
Sep 18, 2019
gnapse
approved these changes
Sep 19, 2019
|
Thanks for approving my contribution. Could I be added to the contributors so I'll appear in README.md? |
Of course! I thought you weren't interested as this is something you could and should've added in your PR. I would've sworn that we had a checkbox for that in the PR template checklist so as to remind people. Would you mind contributing with that too? |
|
OK. On it. |
4 tasks
|
It's done. #131. |
|
@all-contributors please add @yardenshoham for docs |
|
I've put up a pull request to add @yardenshoham! 🎉 |
|
🎉 This PR is included in version 4.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
A typo is being corrected.
Why:
A typo should not exist in the comments.
How:
I fixed the typo and corrected the spelling.
Line 45: Asymettic matchers --> Asymmetric matchers
Checklist: