fix: update getByTestId types

[alexkrolick]

See testing-library/dom-testing-library#29

[kentcdodds]

Sure 👍

[alexkrolick]

I'm actually wondering if getByAltText and other queries should also switch to exact match by default - since regex and functions are supported case-insensitive-partial-match seems a bit gratuitous. Especially since getBy returns the first match automatically which could by some partial match you don't expect.

[kentcdodds]

🎉 This PR is included in version 2.5.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[kentcdodds]

I'm actually wondering if getByAltText and other queries should also switch to exact match by default - since regex and functions are supported case-insensitive-partial-match seems a bit gratuitous.

That's fair. We should make that change in a major version bump though. I was thinking that if you wanted to do a more specific match you could use a regex with ^ and $, but maybe we should make it the inverse: use a regex to be more loose and a string to be more strict.

The thing is, if we consider it from a user's standpoint, they don't care whether the letters are capitals or wither the button says: "Submit form" or "Submit". It's all the same to them. I think that's what motivated the partial match for strings in my mind.

[alexkrolick]

if we consider it from a user's standpoint,

True, but there are other standpoints to consider, i.e., the product spec says button text should be capitalized or a styleguide says all copy should end in ., or for testing compliance with some user-provided theme/translation.

but maybe we should make it the inverse: use a regex to be more loose and a string to be more strict.

I think this makes sense because the most basic "includes text" regex is just /mysubstring/ which is almost the same as "mysubstring".

I could see implementing this by exposing the final options argument to the getAllByAttribute helper to the public methods that use it so that exact: true could toggled.

https://github.com/kentcdodds/dom-testing-library/blob/master/src/queries.js#L73