Skip to content

Update api-async.mdx #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Conversation

lukaselmer
Copy link
Contributor

@lukaselmer lukaselmer commented Oct 25, 2022

I expected waitFor to wait for a condition described in the callback. For example, I expected

await waitFor(() => false)

to wait forever / until the timeout is reached. A better documentation would have helped to realize this quicker.

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit b06cd8b
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/635fbdc09233db0008682287
😎 Deploy Preview https://deploy-preview-1163--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
@timdeschryver timdeschryver merged commit 9177825 into testing-library:main Nov 8, 2022
@timdeschryver
Copy link
Member

@all-contributors please add @lukaselmer for docs

@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @lukaselmer! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants