docs: fix reference error in code sample #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,8 +51,8 @@ export function getByTestId(...args) { | |||
| const result = getAllByTestId(...args) | |||
| if (result.length > 1) { | |||
| throw queryHelpers.getElementError( | |||
| `Found multiple elements with the [data-test-id="${id}"]`, | |||
| container, | |||
| `Found multiple elements with the [data-test-id="${args.id}"]`, | |||
There was a problem hiding this comment.
While the current example isn't correct, I think that suggestion also isn't valid.
args is an array in this case, so accessing id and container won't work.
I can't make a suggestion on the getByTestId method, but I believe the arguments should be:
export function getByTestId(container, id, ...rest) There was a problem hiding this comment.
ah you are right I'll correct it
There was a problem hiding this comment.
Just one more thingy,
- const result = getAllByTestId(...args)
+ const result = getAllByTestId(container, id, ...rest)There was a problem hiding this comment.
oops, thank you. I swear I've written code before 😅
|
@all-contributors please add @lukeingalls for docs |
|
I've put up a pull request to add @lukeingalls! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.