fix: add immediate flag to the navbar run button
#245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smeijer
approved these changes
Jul 5, 2020
smeijer
changed the title
run button
I am happy with it! I found out now that this fix the update of |
|
Yeah, correct. If users are pausing the auto updates, that affects the markup as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#244)
What:
Once
auto-run codeis disabled, clicking onrunmenu voice makes the query be executed.Why:
As told in #244, playing with https://develop.testing-playground.com/ I found out that disabling
auto-run code, clicking onrunmenu voice no query is executed.How:
Checklist:
-[x] add parameter
immediateset to true to the action dispatched by theonClickfunction