refactor: only parse queries in sandbox #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
It's a long story, that is partially explained in #255 (comment), but long story short, we have multiple sources where we evaluate the query against the markup.
This pull-request changes that. The in-memory frame still feels like the best theoretical solution to me, but evaluating in the visible iframe, is the more practical solution.
I've removed the
runInSandboxmethod from the parser. We now always userunUnsafe(in the DOM, against a visual element).Why:
Because the query results in an in-memory iframe differ from the results in a visible iframe.
How:
Checklist:
fixes #255