Skip to content

Conversation

MichaelDeBoey
Copy link
Member

No need to pass format if their's only one.

We can make it default to json whenever we would want to support xml format too

@smeijer
Copy link
Member

smeijer commented May 28, 2020

Don't we need to throw a 501 NOT IMPLEMENTED if the consumer asks for format=xml?

That would mean we can just change the condition:

- params.format !== 'json'
+ params.format === 'xml'

@MichaelDeBoey
Copy link
Member Author

@smeijer Fixed 🙂

@smeijer smeijer changed the title Update oembed.js feat: make oembed requests default to json type May 28, 2020
@smeijer smeijer merged commit a502765 into testing-library:master May 28, 2020
@MichaelDeBoey MichaelDeBoey deleted the patch-1 branch May 28, 2020 15:56
@smeijer
Copy link
Member

smeijer commented May 28, 2020

Thanks 😎

@all-contributors please add @MichaelDeBoey for code

@allcontributors
Copy link
Contributor

@smeijer

I've put up a pull request to add @MichaelDeBoey! 🎉

@MichaelDeBoey
Copy link
Member Author

It's a pleasure to help out! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants