feat: evaluate javascript query in a sandbox #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
smeijer
changed the title
Closed
smeijer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is quite awesome!
The query (javascript) is now evaluated in a sandbox! This means, that having
window.location.href = "https://evil.corp"will no longer redirect the user to a different (potentially bad) domain.This change also demotes the importance of the
previewpane. It now only holds a presentation of themarkup, it's no longer being used to run the queries against. Hence,htmlRoothas been removed from the app context.Thereby, it's no longer required to render the
preview. Which is especially useful when rendering in embed mode (no hiding-workarounds required).fixes #21
resolves #66
closes #67