This repository was archived by the owner on Sep 12, 2024. It is now read-only.
Migrate prompt parsing to magic commands #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osolmaz
added a commit
that referenced
this pull request
Oct 26, 2022
* Minor improvements (#16) * Starting work on Jupyterlite build of icortex * Changed metadata * Minor * Currently trying to fix jupyter_client import * Kernel resources get installed * Removed JupyterLite work for now because it's not as straightforward as expected * Bumped to version 0.1.0 to conform standards * Migrate prompt parsing to magic commands (#18) * Replaced / and // with magic commands %p and %icortex * Execute generated code with InteractiveShell.run_cell() * Cell outputs are saved to ICortexHistory * Minor
osolmaz
added a commit
that referenced
this pull request
Oct 31, 2022
* Minor improvements (#16) * Starting work on Jupyterlite build of icortex * Changed metadata * Minor * Currently trying to fix jupyter_client import * Kernel resources get installed * Removed JupyterLite work for now because it's not as straightforward as expected * Bumped to version 0.1.0 to conform standards * Migrate prompt parsing to magic commands (#18) * Replaced / and // with magic commands %p and %icortex * Execute generated code with InteractiveShell.run_cell() * Cell outputs are saved to ICortexHistory * Minor * Improve documentation (#20) * Added issue templates * Minor * Minor * Minor * Minor * Minor * Minor * Minor * Updated README * Updated README * wip * wip * Minor * Added docstrings and more dcoumentation * Minor * Added rtd config * Added badge * Updated README * Minor * Minor * Minor * Minor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12 was previously created to address the hacky way prompts are parsed and generated code is executed. Now, IPython magic commands seem like an even better solution that uses the existing API and solves the issues stated there.
TODO
%promptand%pmagics to replace/%icortexmagic to replace//