Skip to content

jQuery.fn.gTxt fixes: $.extend(), use of this (patch) #221

Closed
@ghost

Description

From jukka.svahn@rahinaa.biz on July 06, 2012 13:09:22

The JavaScript i18n function, jQuery.fn.gTxt(), has couple smaller issues:

  • using object as the first argument, opts, results in error if the object doesn't contain all three values.
  • it needlessly passes this to jQuery().

To fix the issue that I wrote, this small patch:

  • uses $.extend() to avoid mentioned error from occurring.
  • removes unnecessary passing of this.
  • fixes couple typos in the comments (l18n => i18n), and texpattern.gTxt()'s argument name.

Attachment: textpattern.js.r3928.patch

Original issue: http://code.google.com/p/textpattern/issues/detail?id=217

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions