Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery.fn.gTxt fixes: $.extend(), use of this (patch) #221

Closed
ghost opened this issue Oct 4, 2014 · 1 comment
Closed

jQuery.fn.gTxt fixes: $.extend(), use of this (patch) #221

ghost opened this issue Oct 4, 2014 · 1 comment

Comments

@ghost
Copy link

@ghost ghost commented Oct 4, 2014

From jukka.svahn@rahinaa.biz on July 06, 2012 13:09:22

The JavaScript i18n function, jQuery.fn.gTxt(), has couple smaller issues:

  • using object as the first argument, opts, results in error if the object doesn't contain all three values.
  • it needlessly passes this to jQuery().

To fix the issue that I wrote, this small patch:

  • uses $.extend() to avoid mentioned error from occurring.
  • removes unnecessary passing of this.
  • fixes couple typos in the comments (l18n => i18n), and texpattern.gTxt()'s argument name.

Attachment: textpattern.js.r3928.patch

Original issue: http://code.google.com/p/textpattern/issues/detail?id=217

@ghost ghost added the imported label Oct 4, 2014
@ghost
Copy link
Author

@ghost ghost commented Oct 4, 2014

From r.wetzlmayr on July 08, 2012 20:46:50

This issue was closed by revision r3941 .

Status: Fixed

Loading

@ghost ghost closed this Oct 4, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
0 participants