Namespaces handling improvements. Share methods between the same name scopes. Do not lookup upper scope for qualified name. #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea what I'm doing, I have paws, but I fixed it.
allowDuplicates
for namespace symbols, so you can declare multiple namespaces with the same name. No more "redefinition" error.NamespaceBinder
of the first namespace with the current name, so you can share methods between all scopes.Shading::Decals::foo
but getShading::foo
. Actually we need to check members in the container only, not in the whole binder tree.Known issues:
I don't touch anything with
struct
,enum
scopes. Probably it has similar issues.Don't use nested namespaces with the same name, like
namespace Shading { namespace Shading {} }
it doesn't work properly.example