Angled includes don't lookup files hierarchy, only AdditionalIncludeDirectories. #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isAngled
boolean toGetSearchDirectories
andOpenInclude
methods, it skips the "looking through the hierarchy of files" logic and usesAdditionalIncludeDirectories
instead.IncludeDirectiveTriviaSyntax
now hasIsAngled
boolean that indicates whether the directive uses angled brackets<file.hlsli>
.Parse
function can override thefilePath
ofSourceFile
.AdditionalIncludeDirectories
in all tests, but only for Nvidia cases.I'm also looking at #131 and trying to figure out what it does. It has an
IncludeType
enum with "local" type (oh hey is it angled includes yeas?), but the code doesn't do anything - its just passes arguments and types, but the logic wasn't changed.example