Test failure on macOS

[miketheman]

As part of starting to see how to contribute, I checked out the code, installed the requirements, and ran the tests, which produced this test failure.

________________________________________________________________________ test_output _________________________________________________________________________

tmpdir = local('/private/var/folders/rj/671kk3fx4cj_q5qdpp4kcmmm0000gp/T/pytest-of-miketheman/pytest-1/test_output0')

    def test_output(tmpdir):
        files = """
            unrelated: []
            foo:
                - __init__.py
                - a.py: |
                    from bar import b
            bar:
                - __init__.py
                - b.py
        """
        with create_files(files) as workdir:
>           assert os.getcwd() == workdir
E           AssertionError: assert '/private/var...T/tmpdq01lrqw' == '/var/folders/...T/tmpdq01lrqw'
E             - /private/var/folders/rj/671kk3fx4cj_q5qdpp4kcmmm0000gp/T/tmpdq01lrqw
E             ? --------
E             + /var/folders/rj/671kk3fx4cj_q5qdpp4kcmmm0000gp/T/tmpdq01lrqw

tests/test_cli.py:21: AssertionError

It looks like the os.getcwd call is returning the full path including /private/ preface.

[thebjorn]

Hm.. I do my development on windows and linux, so I don't have any experience with why this is a problem on macOS. The error is coming from the yamldirs package (https://github.com/datakortet/yamldirs - there is a known test failure in the directory2yaml function, but otherwise it should be solid, at least on win+linux).

I have a mac at work and can look at it tomorrow...

[thebjorn]

Travis does osx (slowly..) testcase etc. described at https://stackoverflow.com/questions/58719364/tempfile-mkdtemp-difference-on-osx

[thebjorn]

The latest checkin has a fix for this issue.

[miketheman]

Thanks - sorry it took me a while to come back to this.

That error appears to be resolved on 92f6d6e - but now I'm getting a different error:

========================================================================== FAILURES ==========================================================================
________________________________________________________________________ test_dep2dot ________________________________________________________________________

    def test_dep2dot():
        files = """
            foo:
                - __init__.py
                - a.py: |
                    from . import b
                - b.py
        """
        with create_files(files) as workdir:
            assert simpledeps('foo', '-LDEBUG -vv') == {
                'foo.b -> foo.a'
            }

>           args = pydeps.cli.parse_args(["foo", "--noshow"])

tests/test_dep2dot.py:25:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
pydeps/cli.py:99: in parse_args
    home = os.environ['USERPROFILE' if sys.platform == 'win32' else 'HOME']
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = environ({'TOX_WORK_DIR': '/Users/miketheman/workspace/miketheman/pydeps/.tox', 'TMPDIR': '/var/folders/r_/gq71n9vx3t5c...iketheman/workspace/miketheman/pydeps/.coverage', 'PYTEST_CURRENT_TEST': 'tests/test_dep2dot.py::test_dep2dot (call)'})
key = 'HOME'

    def __getitem__(self, key):
        try:
            value = self._data[self.encodekey(key)]
        except KeyError:
            # raise KeyError with the original key value
>           raise KeyError(key) from None
E           KeyError: 'HOME'

.tox/py37/lib/python3.7/os.py:679: KeyError

Makes me wonder if the HOME envvar is not available to the tox environment?
Which brings around a larger question - is tox still the preferred way to develop/test pydeps? I don't think it's used as part of CI.

[thebjorn]

I should probably remove the tox files. I don't use them because they're horribly slow. I would just create a virtualenv for each version you want to test and run pytest.

[miketheman]

Awesome! I've confirmed that the original error, and the HOME do not trigger on a fresh virtualenv. Thanks!
Closing!