New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 1.3 #3

Merged
merged 2 commits into from Nov 24, 2014

Conversation

Projects
None yet
2 participants
@musically-ut
Contributor

musically-ut commented Nov 23, 2014

No description provided.

@svallory

This comment has been minimized.

Show comment
Hide comment
@svallory

svallory Nov 24, 2014

Member

Closing and reopening to have it tested by travis

Member

svallory commented Nov 24, 2014

Closing and reopening to have it tested by travis

@svallory svallory closed this Nov 24, 2014

@svallory svallory reopened this Nov 24, 2014

@musically-ut

This comment has been minimized.

Show comment
Hide comment
@musically-ut

musically-ut Nov 24, 2014

Contributor

What sorcery is this?
Why did it not complain when I had made the PR in the first place?

Edit: Looks like I spoke too soon. The build does pass. But I still do not understand why this magic step was necessary, though.

Contributor

musically-ut commented Nov 24, 2014

What sorcery is this?
Why did it not complain when I had made the PR in the first place?

Edit: Looks like I spoke too soon. The build does pass. But I still do not understand why this magic step was necessary, though.

svallory added a commit that referenced this pull request Nov 24, 2014

@svallory svallory merged commit b0b308a into theblacksmith:master Nov 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@svallory

This comment has been minimized.

Show comment
Hide comment
@svallory

svallory Nov 24, 2014

Member

Thank you very much!

Member

svallory commented Nov 24, 2014

Thank you very much!

@musically-ut

This comment has been minimized.

Show comment
Hide comment
@musically-ut

musically-ut Nov 24, 2014

Contributor

Thanks! I assume that you will publish it soon to npm?

Contributor

musically-ut commented Nov 24, 2014

Thanks! I assume that you will publish it soon to npm?

@svallory

This comment has been minimized.

Show comment
Hide comment
@svallory

svallory Nov 24, 2014

Member

In a couple minutes :)

Member

svallory commented Nov 24, 2014

In a couple minutes :)

@svallory

This comment has been minimized.

Show comment
Hide comment
@svallory

svallory Nov 24, 2014

Member

done! 👍

Member

svallory commented Nov 24, 2014

done! 👍

@musically-ut

This comment has been minimized.

Show comment
Hide comment
@musically-ut

musically-ut Nov 24, 2014

Contributor

Thanks! I'll get around to upgrading https://github.com/meteor-typescript/meteor-typescript-compiler now. :)

Contributor

musically-ut commented Nov 24, 2014

Thanks! I'll get around to upgrading https://github.com/meteor-typescript/meteor-typescript-compiler now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment