Skip to content

Conversation

@JunQuann
Copy link
Contributor

@JunQuann JunQuann commented Oct 25, 2021

resolves #509

@vercel
Copy link

vercel bot commented Oct 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/the-builder/react-intersection-observer/D8ufZxUWe8su7JHVQj9j6HWnBJZ2
✅ Preview: https://react-intersection-observer-git-fork-junquan-167f2e-the-builder.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 25, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ee7c60f:

Sandbox Source
useInView Configuration
InView render props Configuration
InView plain children Configuration

@JunQuann JunQuann changed the title resolves #509 fix: make ratio return largest threshold smaller than trigger Oct 25, 2021
@thebuilder
Copy link
Owner

Thanks @JunQuann !

@thebuilder thebuilder merged commit f76fa78 into thebuilder:master Oct 25, 2021
@thebuilder
Copy link
Owner

🎉 This PR is included in version 8.32.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intersectionRatio not calculating correctly in triggerIntersection

2 participants