Skip to content

Run CI fo PHP 7.4 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Run CI fo PHP 7.4 #205

wants to merge 1 commit into from

Conversation

OskarStark
Copy link
Collaborator

@OskarStark OskarStark commented Mar 11, 2020 •
edited
Loading

Edit:
It fails with:

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested PHP extension ext-json ^1.5 has the wrong version (7.4.3) installed. Install or enable PHP's json extension.

cc @localheinz

@localheinz
Copy link
Contributor

Blocked by #209.

@moufmouf
Copy link
Member

This is actually just a dependeny problem in composer.json:

safe/generator/composer.json

Line 12 in 353974c

"ext-json": "^1.5",

Let's fix this.

@moufmouf moufmouf mentioned this pull request Mar 16, 2020
Closed
@OskarStark
Copy link
Collaborator Author

Thank you, closing here

@OskarStark OskarStark closed this Mar 16, 2020
@localheinz localheinz mentioned this pull request Mar 20, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @localheinz @moufmouf