Skip to content

Conversation

moufmouf
Copy link
Member

This is a continuation of #205

@localheinz
Copy link
Contributor

Build fails because of #209.

@localheinz
Copy link
Contributor

@moufmouf

Why not merge #209 first?

We don’t need to do all the work twice, do we?

@moufmouf
Copy link
Member Author

@localheinz You are perfectly right. I was attempting to bring a part of #209 in this PR while keeping Rector files for 0.5 and 0.6. But it seems harder that I expected. I'll revert the commits on this branch.

@localheinz
Copy link
Contributor

@moufmouf

I think we can ditch any effort to keep support for unsupported rector/rector versions.

@localheinz
Copy link
Contributor

@moufmouf

What do you think about

  • resetting hard to 884b515
  • rebasing on top of master

?

@moufmouf moufmouf closed this Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants