Change deployment to catalina ROOT

[pieterlukasse]

Change deployment to catalina ROOT so that the final URL reads https://servername.com instead of https://servername.com/cbioportal.

[pieterlukasse]

In the Dockerfile it is as easy as (before the maven step)

RUN rm -rf $CATALINA_HOME/webapps/ROOT

and change

	&& unzip portal/target/cbioportal-*.war -d $CATALINA_HOME/webapps/cbioportal \

to

	&& unzip portal/target/cbioportal-*.war -d $CATALINA_HOME/webapps/ROOT \

⚠️ keep in mind related documentation should also be updated in cbioportal/cbioportal (e.g. like the SAML/Keycloak documentation containing URLs ending in /cbioportal).

[fedde-s]

I'll update the Docker deployment instructions once it gets documented in the upstream cBioPortal deployment manual.

[pieterlukasse]

Yes, ideally this can be done together, with 1 PR to cbioportal/cbioportal (for the documentation) and 1 PR here (for the Docker file).

[fedde-s]

@pieterlukasse, has your feature proposal been reported upstream? This docker setup will follow once it's a documented way to deploy cBioPortal; or maybe as soon as it's in progress there if it immediately greatly benefits our deployments, like we did with cBioPortal/cbioportal#4832.

[pieterlukasse]

No, there is no upstream PR yet.

[pieterlukasse]

Is this file already solving this issue...and introducing a new one (namely a documentation issue)?
https://github.com/cBioPortal/cbioportal/blob/master/docker/web/Dockerfile
CC @inodb