[cpp,go,python,full] Sync single language images with full image if possible and update versions

[chrbayer]

Where possible sync the single language images and the full images and the update versions of development tools in full and other images when in sync:

• cpp: Update cmake to 3.17.4, add tools for 32 bit development
• go: Update to golang 1.14.4
• java: Update to openjdk 11
• python: Update to latest 3.8 release (3.8.3)
• php: Update to latest 7.4 release (7.4.7)

[marcdumais-work]

Thanks for this PR, @chrbayer - This looks like a nice update!

[marcdumais-work]

Why remove this "cleanup" line?

[chrbayer]

I removed the line at this position because I thought it would be a good idea to do the cleanup only once after the last install with apt:

# Theia application
##Needed for node-gyp, nsfw build
RUN apt-get update && apt-get install -y python build-essential && \
  apt-get clean && \
  apt-get autoremove -y && \
  rm -rf /var/cache/apt/* && \
  rm -rf /var/lib/apt/lists/* && \
  rm -rf /tmp/*

[marcdumais-work]

This way of doing it once at the end is good for the final tidiness of the image's file system, but IIUC has a drawback: unless unwanted files are removed from the image in the same docker command (i.e. same image layer) they were created, they will still be in the image but hidden.

So ideally such cleanups would happen for every apt-get command. However I can't say that we've been very careful so far to do this everywhere in our images, so it's not necessarily a deal breaker for this PR.

WDYT?

[chrbayer]

This is a good point which I have not thought about. It will have only a minimum effect on build times, so I'm going to copy the cleanup-block to the end of each apt-get RUN command.
Changes made and pushed, the size of the final image stays the same.

[marcdumais-work]

Changes made and pushed, the size of the final image stays the same.

That part is a bit unexpected. I wonder why? Any theories? I wonder if you were to remove all these cleanups related to installing Debian packages, including the final one, would the image size increase?

[marcdumais-work]

Remove commented-out line?

[marcdumais-work]

BTW, I am curious: did you find a functional difference between the two forms of ENTRYPOINT above?

[chrbayer]

I'm going to delete the commented line after you review and tests are finished, maybe there will be some more changes. I didn't noticed any difference between the two lines, just took the change out of the cpp docker script.

[marcdumais-work]

Thanks @chrbayer - I just did another pass and found just one minor thing. I need to test a bit, but so far the changes look good! I'll let you know how it goes with the tests,

[chrbayer]

@marcdumais-work Thank you very much for reviewing and testing. Please tell me if all tests and reviews are finished, so that I can include all findings in the PR. Should I make a sperate commit or just re-push fixed?

[marcdumais-work]

Should I make a sperate commit or just re-push fixed?

It's fine to force-push your fix(es).

Normally we prefer squashing the commits of PRs but in this case, looking a the commit messages, the breakdown looks logical and if you think you've maintained the changes pretty well insulated, each in their own commit, I have no problem retaining the various commits you have in the PR currently.

Though if we conclude it will make no difference in image size, we could return to a single cleanup at the end for apt temp files (i.e. drop last commit)

[marcdumais-work]

This PR introduces lots of changes, so it will be hard to test everything. I've done some sanity testing, just to confirm that the main things seem to still work. No issue found!

[full]:

• C++ debug (hit breakpoint, inspect value of local variables). Used this example workspace
• C++ Language server working (completions, Hover info, problem markers created for syntax issues, cleared when fixed)
• Python debug and language server working. Used this tutorial as base.
• Go debug and language server working

[cpp]

• C++ debug (hit breakpoint, inspect value of local variables). Used this example workspace
• C++ Language server working (completions, Hover info, problem markers created for syntax issues, cleared when fixed)

[python]

• Python debug and language server working. Used this tutorial as base.
• Go debug and language server work

[marcdumais-work]

@chrbayer Ready for your final update.

Can you let me know if anything substantial changes vs the current version, that would make it worth it to redo some of the testing?

[chrbayer]

@marcdumais-work Thank you very much for all you support! The only changes I did are the two proposed changes:

1. Remove the commented line at the end of the cpp and full docker files
2. Removing the apt cleanup after each step and do the cleanup only at the end of the script

[chrbayer]

For me this PR should now be complete :-)

[marcdumais-work]

LGTM, thanks @chrbayer for this contribution!