This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
repo: drop support for node 10 when building images #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
force-pushed
the
vf/node-12
branch
3 times, most recently
from
ab4c1e1 to
312e4f3
Compare
|
Wow, something seems wrong with CI. @vince-fugnitto do you know if these failures happen when you build and run the tests locally? |
1 task
vince-fugnitto
force-pushed
the
vf/node-12
branch
from
312e4f3 to
53962ab
Compare
vince-fugnitto
changed the title
vince-fugnitto
force-pushed
the
vf/node-12
branch
3 times, most recently
from
340526d to
e8c873e
Compare
5 tasks
The following commit updates all images to use `node 12` instead of `10` as it is dropped in favor of the new LTS. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/node-12
branch
from
e8c873e to
1fb3d5e
Compare
|
I rebased the pull-request to pick up changes from #396. |
marcdumais-work
approved these changes
Aug 13, 2020
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The following commit includes the following updates:
The images and build are updated to make use of
Node v12.18.3 (LTS)instead ofNode 10which will be dropped in upcoming releases. The bump in Node version is necessary for security updates, vscode extension compatibility and since it is the new LTS.How to test
The CI should successfully pass (given that no other errors currently fail the build):
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com