This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
[deb] fix image #448
Merged
[deb] fix image #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal fix for this image. The example app would need to be updated to support vscode extensions to be useful. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
vince-fugnitto
approved these changes
Dec 7, 2020
|
@marcdumais-work fine to merge? |
|
yes, thanks for the reminder. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal fix for this image. The example app would need to be updated
to support vscode extensions to be useful.
I was thinking that this may be the only example we have of packaging a
browser Theia app, along with the
rpmexample. So we may considerupdating the app, building a
.deband using it to install the app in DEBIAN-based containers. (not in this PR though)
Signed-off-by: Marc Dumais marc.dumais@ericsson.com