Remove rubric styling #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re you question: In the beginning, the release notes style had much less structure, and another bold heading was too much. When I refactored the docs on Christmas 2019, building in more structure into the release notes, one should have gotten rid of it already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into scverse/scanpy#1581, and saw examples headings were under the rubric class, which has custom styling applied here. I've previously been unhappy with how the "rubric" titles looked in the release notes. This PR removes the custom styling and I think looks much better in both places. It's not clear to me why this styling was added in the first place however, so I could be missing something.
Change logs
This PR
Previous
Examples sections for docs
This PR
Previous