Skip to content

Conversation

flying-sheep
Copy link
Collaborator

This should do the trick.

Closes #35

@ivirshup
Copy link
Contributor

  • Have you checked if the scanpy docs build using this PR? (This might be a good CI check)
  • How do we go about making a release after this, as the last fix didn't get merged?

@flying-sheep
Copy link
Collaborator Author

Good question. We could add the feature to get_version in which it only returns a VCS version if the git root matches, but idk if that would fix it or just throw a different error because now it can’t find any version.

@flying-sheep flying-sheep merged commit 1f6a921 into master Jul 13, 2021
@flying-sheep flying-sheep deleted the sphinx-4.1 branch July 13, 2021 10:57
@flying-sheep
Copy link
Collaborator Author

OK, I updated get_version. We don’t have to make another hacky hardcode release here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLTypedField incompatible with sphinx 4.1.0
2 participants