Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show elapsed time in the progress bar #36

Closed
jmuheim opened this issue Feb 7, 2013 · 5 comments
Closed

Show elapsed time in the progress bar #36

jmuheim opened this issue Feb 7, 2013 · 5 comments
Labels
outdated Inactive - Outdated

Comments

@jmuheim
Copy link

jmuheim commented Feb 7, 2013

ETA doesn't really give much useful information. It would be more useful to just see how long the tests are running already.
@jeffkreeftmeijer
Copy link
Contributor

I've created Fuubar when I was dealing with some very slow test suites and I believe a lot of its users are still dealing with problems like that, so I'd like to keep the ETA in there.

The elapsed time is something that dropped out when updating to the new version of https://github.com/jfelchner/ruby-progressbar, and there should be quite a simple way to show it. Could you take a look at that and send a pull request if you get it to work?

@jmuheim
Copy link
Author

jmuheim commented Feb 7, 2013

Okay, I understand, it was only a suggestion. 👍

Sadly I don't have much time myself at the moment. Maybe I will look into this later.

@jeffkreeftmeijer
Copy link
Contributor

No problem at all, I just wanted to let you know I'm open for a pull request like that and that I don't have a lot of time to do it myself soon. Oh, and I've updated the issue's title.

If anyone else wants to pick this up, please be my guest. :)

@jfelchner
Copy link
Collaborator

@jeffkreeftmeijer did it ever show the elapsed time other than when the bar was finished? I didn't think so. In any event, I'm planning on making the progress bar format something that can be configured. We'll leave the default as-is, but if someone wants to change it, they can do it easily.

jfelchner added a commit that referenced this issue Apr 24, 2016
@jfelchner
Merge branch 'feature/remove-rspec-instafail' into develop - Closes #36…
edcc916 
…, #29, #20, #33

* feature/remove-rspec-instafail:
  Big refactoring to use the capabilities exposed by RSpec's formatters as well as replacing the specs with ones which are more representative
  Add .ruby-version file
  Use RSpec's helpers to output the failures at the proper time
  Remove all references to instafail
  Remove rspec-instafail from the project
@github-actions
Copy link

This issue has been closed automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the outdated Inactive - Outdated label Dec 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated Inactive - Outdated
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeffkreeftmeijer @jfelchner @jmuheim