Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'rspec-instafail' dependency from gemspec? #20

Closed
dougireton opened this issue Aug 6, 2011 · 4 comments
Closed

Remove 'rspec-instafail' dependency from gemspec? #20

dougireton opened this issue Aug 6, 2011 · 4 comments
Labels
outdated Inactive - Outdated

Comments

@dougireton
Copy link

Hey, I just noticed that RSpec core has a --fail-fast command line option now. Do you still need the 'rspec-instafail' dependency in the gemspec, or can it be removed?

@jeffkreeftmeijer
Copy link
Contributor

Hey Doug,

I really want to get rid of that dependency, but --fail-fast stops the suite after the first failure (http://jeffkreeftmeijer.com/2010/making-rspec-stop-operation-immediately-after-failing/). Using instafail, the specs would continue running after the first fail, but print out their error immediately.

I'll keep this open, since this is still something we need to do. Thanks for reporting!

@nofxx
Copy link

nofxx commented Mar 27, 2012

rspec-instafail changed things on v0.2.3.
Can't require 'rspec/instafail'. For search purposes:

fuubar.rb:3:in `require': cannot load such file -- rspec/instafail

@jeffkreeftmeijer
Copy link
Contributor

@nofxx I started a new issue for that one: #29

jfelchner added a commit that referenced this issue Dec 15, 2013
…, #29, #20, #33

* feature/remove-rspec-instafail:
  Big refactoring to use the capabilities exposed by RSpec's formatters as well as replacing the specs with ones which are more representative
  Add .ruby-version file
  Use RSpec's helpers to output the failures at the proper time
  Remove all references to instafail
  Remove rspec-instafail from the project
jfelchner added a commit that referenced this issue Apr 24, 2016
…, #29, #20, #33

* feature/remove-rspec-instafail:
  Big refactoring to use the capabilities exposed by RSpec's formatters as well as replacing the specs with ones which are more representative
  Add .ruby-version file
  Use RSpec's helpers to output the failures at the proper time
  Remove all references to instafail
  Remove rspec-instafail from the project
@github-actions
Copy link

This issue has been closed automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the outdated Inactive - Outdated label Dec 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated Inactive - Outdated
Development

No branches or pull requests

4 participants