-
Notifications
You must be signed in to change notification settings - Fork 18
Change from Email::Address, which is marked as deprecated, to the com… #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…patible Email::Address::XS.
Bah, broke the build. Please update the |
New pull request created for Build.PL. Sorry for the breakage - I'm not much of a perl module expert. |
@@ -1471,10 +1471,10 @@ sub output_headers { | |||
# Q-Encode the phrase part of recipient headers. | |||
my $norm; | |||
if (PERL58) { | |||
require Email::Address; | |||
require Email::Address::XS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! No need to put Email::Address::XS
into if(PERL58)
block. Module Email::Address::XS
is compatible and tested back to Perl version 5.6.0.
Would one of you like to take over maintenance of this fine module? |
Sorry, but I do not have time for maintaining another module :-( |
I'd be happy to, but to be honest, I don't know if I'm qualified with the meagre Perl skills and virtually zero Perl module knowledge that I have. If you're willing to put up with some questions, mainly regarding building and testing modules, I'd be keen to give it a shot though. |
I'm happy to answer questions. Feel free to email me. |
Thanks. I'll be in contact. |
With this patch applied, the test suite throws tons of Full log at https://bugs.debian.org/887549 |
That's unfortunate. I'll look into this. |
I've created pull request #22 to fix this the issue mentioned by gregoa above. |
Change from Email::Address, which is marked as deprecated, to the compatible Email::Address::XS.
Perl-Email-Project/Email-Address@fcc869a