Skip to content

Change from Email::Address, which is marked as deprecated, to the com… #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Conversation

mpghf
Copy link
Collaborator

@mpghf mpghf commented Apr 24, 2018

Change from Email::Address, which is marked as deprecated, to the compatible Email::Address::XS.
Perl-Email-Project/Email-Address@fcc869a

@theory theory merged commit c69547c into theory:master Apr 24, 2018
@theory
Copy link
Owner

theory commented Apr 24, 2018

Bah, broke the build. Please update the Build.PL file, too.

@mpghf
Copy link
Collaborator Author

mpghf commented Apr 25, 2018

New pull request created for Build.PL. Sorry for the breakage - I'm not much of a perl module expert.

@@ -1471,10 +1471,10 @@ sub output_headers {
# Q-Encode the phrase part of recipient headers.
my $norm;
if (PERL58) {
require Email::Address;
require Email::Address::XS;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! No need to put Email::Address::XS into if(PERL58) block. Module Email::Address::XS is compatible and tested back to Perl version 5.6.0.

@theory
Copy link
Owner

theory commented Jun 8, 2018

Would one of you like to take over maintenance of this fine module?

@pali
Copy link

pali commented Jun 8, 2018

Sorry, but I do not have time for maintaining another module :-(

@mpghf
Copy link
Collaborator Author

mpghf commented Jun 11, 2018

I'd be happy to, but to be honest, I don't know if I'm qualified with the meagre Perl skills and virtually zero Perl module knowledge that I have.

If you're willing to put up with some questions, mainly regarding building and testing modules, I'd be keen to give it a shot though.

@theory
Copy link
Owner

theory commented Jun 11, 2018

I'm happy to answer questions. Feel free to email me.

@mpghf
Copy link
Collaborator Author

mpghf commented Jun 12, 2018

Thanks. I'll be in contact.

@gregoa
Copy link

gregoa commented Jun 26, 2018

With this patch applied, the test suite throws tons of Argument contains empty address at /build/libsvn-notify-perl-2.86/blib/lib/SVN/Notify.pm line 1476.warnings. This doesn't look right to me ...

Full log at https://bugs.debian.org/887549

@mpghf
Copy link
Collaborator Author

mpghf commented Jun 27, 2018

That's unfortunate. I'll look into this.

@mpghf
Copy link
Collaborator Author

mpghf commented Jun 27, 2018

I've created pull request #22 to fix this the issue mentioned by gregoa above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants