Skip to content

Change from Email::Address, which is marked as deprecated, to the com… #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Change from Email::Address, which is marked as deprecated, to the com… #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/SVN/Notify.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1471,10 +1471,10 @@ sub output_headers {
# Q-Encode the phrase part of recipient headers.
my $norm;
if (PERL58) {
require Email::Address;
require Email::Address::XS;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! No need to put Email::Address::XS into if(PERL58) block. Module Email::Address::XS is compatible and tested back to Perl version 5.6.0.

$norm = sub {
return join ', ' => map {
my ($addr) = Email::Address->parse($_);
my ($addr) = Email::Address::XS->parse($_);
if ($addr) {
if (my $phrase = $addr->phrase) {
$addr->phrase(Encode::encode( 'MIME-Q', $phrase ));
Expand Down